Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Django Commons pypi-github release process #2017

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Convert to Django Commons pypi-github release process #2017

merged 2 commits into from
Oct 27, 2024

Conversation

tim-schilling
Copy link
Member

@tim-schilling tim-schilling commented Oct 16, 2024 •
edited
Loading

Description

This switches us to the Django Commons release process.

References: django-commons/membership#34
References: #1918

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@tim-schilling tim-schilling marked this pull request as ready for review October 23, 2024 17:03
matthiask
matthiask approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we have both TestPyPI and PyPI in there?

I'm not using trusted publishing yet (unfortunately), so I cannot say if this would work, but it certainly looks good to me.

@tim-schilling tim-schilling merged commit 89449b6 into main Oct 27, 2024
53 checks passed
@tim-schilling tim-schilling deleted the django-commons-release branch October 27, 2024 13:33
@tim-schilling
Copy link
Member Author

This comes from the Django Commons example and is from the pypi tutorial. I'm about 99% sure it'll work for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiask matthiask matthiask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tim-schilling @matthiask