Merge pull request #92 from benjaoming/clean-fk-access

Do not access Settings.user when Settings.pk is unset
django-wiki · Dec 30, 2019 · e0cd63a · e0cd63a
2 parents c7b2250 + 701e77d
commit e0cd63a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/django_nyt/__init__.py b/django_nyt/__init__.py
@@ -1,5 +1,5 @@
 _disable_notifications = False
 
-__version__ = "1.1.4"
+__version__ = "1.1.5"
 
 default_app_config = "django_nyt.apps.DjangoNytConfig"
diff --git a/django_nyt/models.py b/django_nyt/models.py
@@ -100,7 +100,7 @@ class Meta:
         verbose_name_plural = _('settings')
 
     def clean(self):
-        if not self.is_default:
+        if not self.is_default and self.pk and self.user:
             default_settings = Settings.objects.filter(
                 user=self.user,
                 is_default=True,

diff --git a/docs/release_notes.rst b/docs/release_notes.rst
@@ -1,6 +1,15 @@
 Release Notes
 =============
 
+1.1.5
+-----
+
+Fixed
+^^^^^
+
+ * Do not access ``Settings.user`` in ``Settings.clean()`` on blank new objects :url-issue:`92`
+
+
 1.1.4
 -----
 
@@ -9,6 +18,7 @@ Added
 
  * Django 3.0 support (added to test matrix)
 
+
 1.1.3
 -----