Added tabs for queues. #266
Conversation
ontowhee
force-pushed
the
ticket-queue-tabs
branch
from
72675ad to
d3c7c0c
Compare
ontowhee
force-pushed
the
ticket-queue-tabs
branch
from
d3c7c0c to
f32f7d6
Compare
|
Instead of hardcoding the links, I tried using a trac "Component" to add a new navigation bar. This new nav bar only shows up when the page is on View Tickets tab (path is "/query"). I haven't been able to set the correct active item within trac_queue_navbar.mov |
There was a problem hiding this comment.
Nice one, @ontowhee. Some minor questions for you and this should be g2g.
| implements(INavigationContributor) | ||
|
|
||
| def get_active_navigation_item(self, req): | ||
| stage = req.args.get("stage") |
There was a problem hiding this comment.
Tried to get this going locally, would you know anything about this error?
Cannot find an implementation of the IRequestHandler interface named CustomWikiModule. Please check that the Component is enabled or update the option [trac] default_handler in trac.ini.
There was a problem hiding this comment.
Where are you seeing the error? I'm not seeing it. I'm running the project in the docker container, and I have default_handler = CustomWikiModule in trac.ini. Is there a library version mismatch?
Is the error happening at lines 94-97, which is for CustomSubNavigationBar? I wonder why the message reports CustomWikiModule.
There was a problem hiding this comment.
I did see this error when the project was reloading after some changes. I noticed the css wasn't loading properly either. The error didn't appear after I restarted the container and refreshed the page.
There was a problem hiding this comment.
Thanks for checking. Restarting the container didn't help. I must have missed some necessary setup?
There was a problem hiding this comment.
Huzzah! cd DjangoPlugin && setup.py seemed to do the trick.
|
@jacobtylerwalls Thank you so much for the review! I've addressed your points. I think it's looking a lot better now. 
|
|
Thanks @ontowhee! |
|
Thank you @jacobtylerwalls! I'm excited to see when this goes live! |
|
Hey @bmispelon just putting on your radar that this change is worth deploying when convenient. Thanks! |
Fix Issue #259
This is another attempt to make "queues" easy to access. Instead of using javascript as was done in PR #264, this attempts to add tabs.
Forum discussion: https://forum.djangoproject.com/t/proposal-clarify-ticket-statuses-and-queues/41496/