Skip to content

Conversation

@calebjubal
Copy link
Contributor

Description

This pull request fixes the issue where table links in dark mode were not clearly visible when hovered. The color contrast was too low, making the text hard to read.

Changes Made

  • Added a new SCSS variable for dark mode:

    Screenshot 2025-10-11 102324
  • Updated the link hover color in dark mode tables:

    Screenshot 2025-10-11 102311
  • And changed the default color of the table links in light mode for contrast:

    Screenshot 2025-10-11 102251
  • Replaced static color references with theme variables where applicable for consistency.

Screenshots

Dark Mode:
image

Light Mode:
image

Testing

  • Verified in both light and dark themes.

  • Confirmed that hover color works as expected in dark mode.

  • Checked that no other UI components or color variables were affected.

Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I see that you have changed the color for prefers-color-scheme and the hover color in data-theme=dark. Both the changes need to be applied in both the places, so that all dark mode scenarios are covered. I have left inline comments for the same. Once that is fixed, I think we can merge this PR.

Copy link
Contributor Author

@calebjubal calebjubal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SaptakS SaptakS merged commit eaf549a into django:main Oct 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient contrast on hover state for links in tables in dark mode

2 participants