Skip to content

Conversation

@CuriousLearner
Copy link
Member

Underline to get PyCharm for 30% off to indicate it's a link.

Screenshot 2025-10-23 at 10 09 19 AM

@CuriousLearner CuriousLearner requested review from a team and bmispelon October 23, 2025 14:09
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

This looks good visually, but the original ask was that the whole text stays a link, and to either underline the "get PyCharm for 30% off" only, or if not possible then the whole text.

@CuriousLearner
Copy link
Member Author

Underlining the get PyCharm for 30% off:

Screenshot 2025-10-24 at 10 41 56 AM

On hover default state underlines the whole banner:

Screenshot 2025-10-24 at 10 42 02 AM

It looks a little odd; we may remove the underline on the hover state if there is a preference.

@adamzap
Copy link
Member

adamzap commented Oct 30, 2025

@CuriousLearner Should we close this since #2299 was merged?

@CuriousLearner
Copy link
Member Author

Sure, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants