Remove redundant if condition from django debug toolbar init #2313
+18
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEBUG is defined as True in the same file. Because the variable value is hardcoded, `if DEBUG` will always give same result - hence not needed
ulgens
commented
Nov 2, 2025
Comment on lines
+48
to
+51
| try: | ||
| import debug_toolbar # NOQA | ||
| except ImportError: | ||
| pass |
Member
Author
There was a problem hiding this comment.
Do we have a case where developers use the dev settings without installing the dev requirements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEBUG is defined as True in the same file. Because the variable value is hardcoded,
if DEBUGwill always give same result - hence not needed