-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for internationalisation and localisation and French as a language #27
Conversation
Hey @sheenarbw, you can review the Django parts, and I will have Ariane check my Google-translated French. Thanks. |
@Arya-AD the translations are in locale/fr/LC_MESSAGES/django.po. I have done for the homepage html and the links. |
Ok, I'll review in few hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @amakarudze the translations are globally well done. Thanks!
Thanks @Arya-AD. I have accepted your suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks @amakarudze
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anna,
Good start but there are a few strange things happening in here.
templates/page_home.html
Outdated
<!-- <h2 class="text-5xl font-bold text-tz_flag_blue-600 mb-4">Arusha, Tanzania</h2> | ||
<p class="text-3xl font-semibold text-gray-700 mb-2">11 - 16 August</p> --> | ||
|
||
<p>We are in the early phases of planning the next DjangoCon Africa!</p> | ||
<p>Follow our socials to stay up to date</p> | ||
<p>{% translate "We are in the early phases of planning the next DjangoCon Africa!" %}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at the top right of the screenshot I sent.
Maybe I'm doing something wrong. I was only able to get part of the page translated to french when I tried to run it in french.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheenarbw I am not sure what you're doing wrong, but you're not supposed to translate the page to French. You're supposed to use the French locale. That's how Django works, through locales and not translations.
The translations are done manually by people, which is why I needed @Arya-AD's help with the file locale/fr/LC_MESSAGES/django.po where the translations are for French.
Check https://docs.djangoproject.com/en/5.1/topics/i18n/translation/, and you'll see I have done what is humanly possible to enable internationalisation. For translations for all other pages, @Arya-AD would need to help us as they are done manually.
I also used French as the starting point because we already have a French-speaking person who did translations we couldn't use last year due to the setup of our website, which didn't allow it. I didn't pick Portuguese or Spanish or any other language because we don't have a person to translate the pages for us manually.
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Co-authored-by: Ariane Djeupang <[email protected]>
Changes in this PR