Add support for impersonation to the CustomServiceAccount impl #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not have much time to come back to it. I will try to test it within days and let you know. Thanks! |
|
@djc gave it a go and it works for my use-case. Thanks :) |
zhrebicek
approved these changes
Apr 9, 2024
|
@zhrebicek sorry for the long wait -- thanks for the quick feedback! Published gcp_auth v0.11.1 at registry |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less invasive replacement for #92.
@zhrebicek sorry it took me a while to get back to this, are you still interested? I think this could do the job, any thoughts? (The meat of the change here is in the last commit, feel free to ignore the refactoring before that.)
@nrempel does this address your use case?
(Note that there exists an
impl TryFrom<CustomServiceAccount> for AuthenticationManager.)