Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a panic in text color lens #89

Merged
merged 6 commits into from
Oct 28, 2023
Merged

Fixed a panic in text color lens #89

merged 6 commits into from
Oct 28, 2023

Conversation

wainwrightmark
Copy link
Contributor

Hi. The TextColorLens can panic if the text section it's looking for isn't there. I just got it to do nothing in that case instead.

djeedai
djeedai requested changes Jun 13, 2023
View reviewed changes
Copy link
Owner

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please add a line in the CHANGELOG for this?

@djeedai djeedai added the bug Something isn't working label Jun 13, 2023
@wainwrightmark
Copy link
Contributor Author

Thanks! Can you please add a line in the CHANGELOG for this?

Have done. Also updated the tests as coverage had gone done.

@djeedai djeedai merged commit 7a03bdf into djeedai:main Oct 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeedai djeedai djeedai approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wainwrightmark @djeedai