Add support for rails 7.1 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djezzzl btw I'm going to go ahead and try to add rails 7.1 to the github CI matrix. as well as add a unit test to the presence checker 👍🏼 |
chaadow
commented
Oct 15, 2023
lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb
Show resolved
Hide resolved
Fixes djezzzl#215. rails 7.1 recently added this new default [configuration option](https://guides.rubyonrails.org/configuring.html#config-active-record-belongs-to-required-validates-foreign-key ) When set to false ( default in rails 7.1 ) an `if` option is added to the belongs_to option. which makes it not compatible with the current `WEAK_OPTIONS` array. To cover this new case, and as a pre-check, we make sure that we're on rails 7.1.0 minimum as well as the ActiveRecord option ( `ActiveRecord.belongs_to_required_validates_foreign_key` ) is set to false to mitigate issues with real `if` conditions. We also check that the if condition is coupled with a `message` option set to `required` This commit also adds rails 7.1 to the CI matrix.
|
rebased and squashed |
djezzzl
reviewed
Oct 15, 2023
|
Thank you very much for your contribution! I'll update a changelog and release it today! Please let me know if you have any more ideas to make this gem more helpful. Have a great day and the upcoming week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #215
rails 7.1 recently added this new default configuration option
When set to false ( default in rails 7.1 ) an
ifoption is added to the belongs_to option. which makes it not compatible with the currentWEAK_OPTIONSarray.To cover this new case, and as a pre-check, we make sure that we're on rails 7.1.0 minimum as well as the ActiveRecord option (
ActiveRecord.belongs_to_required_validates_foreign_key) is set to false to mitigate issues with realifconditions. We also check that the if condition is coupled with amessageoption set torequiredThis commit also adds rails 7.1 to the CI matrix.
cc @djezzzl @agrobbin