Tried to debug EMDUnifrac_weighted_flow
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``diffab`` should be accumulated through ``for j in pos[i].union(neg[i])`` (in line 295), but it not was so. To be clear, a variable ``diffab_amount`` was introduced instead of using ``diffab`` objects in different ways. I'd like to check if the diffab vectors for weighted and weighted_flow are same!
|
Wow, I have no idea how I missed this PR @pokapoka-jigoku ! Apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diffabshould be accumulated throughfor j in pos[i].union(neg[i])(in line 295), but it not was so.To be clear, a variable
diffab_amountwas introduced instead of usingdiffabobjects in different ways.I'd like to check if the diffab vectors for weighted and weighted_flow are same!
(I was moved by your algorithms of EMDUnifrac. I'd like more people to use your invention :) )