Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#259 - Wrong entities are removed when iterating through CAS #260

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Jul 22, 2022

  • Fixed problem by ensuring that annotations are compared in the indices not only according to their offsets but also to their identity
  • Added test case

@reckart reckart added this to the 0.7.3 milestone Jul 22, 2022
- Fixed problem by ensuring that annotations are compared in the indices not only according to their offsets but also to their identity
@reckart reckart self-assigned this Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #260 (e9917cc) into main (8c2e058) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files           5        5           
  Lines        1869     1869           
=======================================
  Hits         1784     1784           
  Misses         85       85           
Impacted Files Coverage Δ
cassis/cas.py 95.70% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@reckart reckart merged commit d556f43 into main Jul 22, 2022
@reckart reckart deleted the bugfix/259-Wrong-entities-are-removed-when-iterating-through-CAS branch July 22, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant