Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#312 - Ability to retrieve a type by its short name #313

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented May 4, 2024

What's in the PR

  • Changed get_type and contains_type to be able to handle non-ambiguous short names

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Changed get_type and contains_type to be able to handle non-ambiguous short names
@reckart reckart added this to the 0.10.0 milestone May 4, 2024
@reckart reckart self-assigned this May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.11%. Comparing base (1fa0932) to head (4b0b5b2).

Files Patch % Lines
cassis/typesystem.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   95.18%   95.11%   -0.07%     
==========================================
  Files           5        5              
  Lines        1992     2007      +15     
==========================================
+ Hits         1896     1909      +13     
- Misses         96       98       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reckart reckart merged commit 12f7c22 into main May 4, 2024
5 of 7 checks passed
@reckart reckart deleted the feature/312-Ability-to-retrieve-a-type-by-its-short-name branch May 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant