-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#316 - Switch to using plain pyproject.toml #317
base: main
Are you sure you want to change the base?
#316 - Switch to using plain pyproject.toml #317
Conversation
- Remove setup.py - Switch to pyproject.toml - Update GitHub actions to use poetry - Clean up code a bit according to feedback from flake8 - Update release guide
- Use ruff - Address linter issues in json.py
d608947
to
8f43b16
Compare
- Manage dependencies in requirements files - Use pip-tools to manage dependencies - Remove poetry
8f43b16
to
28478b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 95.47% 91.43% -4.04%
==========================================
Files 5 5
Lines 2009 2009
Branches 0 520 +520
==========================================
- Hits 1918 1837 -81
Misses 91 91
- Partials 0 81 +81 ☔ View full report in Codecov by Sentry. |
@DavidHuebner does this look more reasonable to you? |
The project structure looks fine, but I have some doubts if pinning all the versions is really a good idea for dkpro-cassis (sorry if I only make the argument now). So, generally cassis is installed as part of larger projects as an auxiliary module and not as a standalone library. We should be flexible to deal with the dependency ranges in other libraries. For instance, Hence, I would actually prefer ranges over specific versions. |
I don't mind having ranges for the declaration of compatibility, but I would like to have pinned versions for builds (in particular testing, documentation, etc.). Is that possible? I.e. when setting up the venv for building, I want to have fixed versions. When another library uses cassis, it should look at the compatibility declarations in the package metadata. My understanding is that the version declarations in |
I see. I think you are right. When installing from PyPI, the |
What's in the PR
How to test manually
Automatic testing
Documentation