Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerization, lcov, fix env, scripts, aliases #2

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

FedokDL
Copy link
Member

@FedokDL FedokDL commented Oct 9, 2023

  1. Add containerization. Add .devcontainer.json for VSCode for comfortable development. Nothing else needs to be installed locally, only Docker.
  2. Fix type format inside .env.example. Now the scripts are working.
  3. Add aliases: @contracts and @tests. Getting rid of the ../../ style.
  4. Add lcov to container and plugin for vscode. Using the coverage report is now easier.
  5. I think it is highly impractical to store other repositories inside a repository as submodules. As it increases its size a lot, moreover submodules are quite demanding and many times there were errors from the git when trying to install something.
    I removed submodules from the repository and instead added a Makefile, which allows us to install the packages we need with a specific version. This command is already installed in the container, but if someone doesn't want to use it, they can simply copy the command to their personal terminal.

@FedokDL FedokDL added bug Something isn't working feature New feature or request labels Oct 9, 2023
@FedokDL FedokDL self-assigned this Oct 9, 2023
@FedokDL FedokDL changed the title Add containerization, fix env, scripts, aliases Add containerization, lcov, fix env, scripts, aliases Oct 9, 2023
@FedokDL FedokDL requested a review from Arvolear October 9, 2023 15:21
scripts/deploy.s.sol Outdated Show resolved Hide resolved
.devcontainer.json Outdated Show resolved Hide resolved
Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 63cf2e7 into master Oct 14, 2023
1 check passed
@Arvolear Arvolear deleted the feat/refactoring branch October 14, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants