Improved message structure

src/core/compile/CompilationFilesResolver.ts

@@ -117,6 +117,7 @@ export class CompilationFilesResolver {
       filteredResolvedFilesInfo = resolvedFilesInfoToCompile;
     }
 
+    Reporter!.reportAllWarnings(spinnerId);
     Reporter!.reportCircuitFilesResolvingResult(spinnerId);
 
     const filteredSourceNamesToCompile: string[] = filteredResolvedFilesInfo.map(

src/core/dependencies/parser/CircomTemplateInputsVisitor.ts

@@ -141,7 +141,7 @@ export class CircomTemplateInputsVisitor extends CircomVisitor<void> {
         ctx.expression() instanceof BlockInstantiationExpressionContext ||
         ctx.expression() instanceof DotExpressionContext
       ) {
-        Reporter?.reportUnsupportedExpression(ctx.expression().getText());
+        Reporter?.reportUnsupportedExpression(this._templateName, ctx.expression());
 
         return [0n];
       }

src/reporter/ReporterFacade.ts

@@ -4,7 +4,7 @@ import debug from "debug";
 import { VerifierLanguageType } from "@solarity/zkit";
 
 import { CircuitArtifact } from "../types/artifacts/circuit-artifacts";
-import { CompilationInfo, CircuitSetupInfo } from "../types/core";
+import { CompilationInfo, CircuitSetupInfo, SimpleParserRuleContext } from "../types/core";
 import {
   ProgressReporter,
   CircuitFilesResolvingReporter,
@@ -222,8 +222,14 @@ class ReporterFacade {
     this._progressReporter.updateProgressBarValue(valueToAdd);
   }
 
-  public reportUnsupportedExpression(contextText: string) {
-    this._warningsReporter.reportUnsupportedExpression(contextText);
+  public reportUnsupportedExpression(templateName: string, context: SimpleParserRuleContext) {
+    this._warningsReporter.reportUnsupportedExpression(templateName, context);
+  }
+
+  public reportAllWarnings(spinnerId: string | null) {
+    if (!this._warningsReporter.hasWarnings()) return;
+
+    this._warningsReporter.reportAllWarnings(spinnerId);
   }
 
   public verboseLog(namespace: string, formatterStr: string, logArgs: any[] = []) {

src/reporter/SpinnerProcessor.ts

@@ -31,6 +31,16 @@ export class BaseSpinnerProcessor {
     this._idToSpinnerData.delete(spinnerId);
   }
 
+  public warnSpinner(spinnerId: string, warningMessage: string) {
+    const spinnerData = this._idToSpinnerData.get(spinnerId);
+
+    if (!spinnerData) return;
+
+    spinnerData.spinner.warn(warningMessage);
+
+    this._idToSpinnerData.delete(spinnerId);
+  }
+
   public getWorkingTime(spinnerId: string, fractionDigits: number = 2): string | undefined {
     const spinnerData = this._idToSpinnerData.get(spinnerId);
 

src/reporter/reporters/WarningsReporter.ts

@@ -1,11 +1,44 @@
+import { SimpleParserRuleContext } from "../../types/core";
+
+import { SpinnerProcessor } from "../../reporter";
 import { BaseReporter } from "../../reporter/reporters/BaseReporter";
 
 export class WarningsReporter extends BaseReporter {
-  public reportUnsupportedExpression(contextText: string) {
+  public warnings: Set<string> = new Set();
+
+  constructor(quiet: boolean) {
+    super(quiet);
+
+    this.warnings = new Set();
+  }
+
+  public reportUnsupportedExpression(templateName: string, context: SimpleParserRuleContext) {
     if (this.isQuiet()) return;
 
-    console.warn(
-      `Expression structure: ${contextText} not supported if used to determine the dimension of an input signal!`,
+    this.warnings.add(
+      `Inside the ${templateName} circuit (${context.start.line}:${context.start.column})\r
+      \rThe expression structure: ${context.getText()} not supported if used to determine the dimension of an input signal!`,
+    );
+  }
+
+  public reportAllWarnings(spinnerId: string | null) {
+    if (this.isQuiet() || !spinnerId) return;
+
+    const resolvingTimeMessage: string = this._getSpinnerWorkingTimeMessage(
+      SpinnerProcessor!.getWorkingTime(spinnerId),
+    );
+
+    SpinnerProcessor!.warnSpinner(
+      spinnerId,
+      `Circuits are ready for the compilation ${resolvingTimeMessage}. But the analysis ended with warnings:`,
     );
+
+    for (const warning of this.warnings) {
+      console.warn(warning);
+    }
+  }
+
+  public hasWarnings(): boolean {
+    return this.warnings.size > 0;
   }
 }

src/types/core/dependencies/parser/circom-files-visitor.ts

@@ -21,3 +21,20 @@ export type CircomFileData = {
   mainComponentInfo: MainComponent;
   templates: Templates;
 };
+
+export interface Token {
+  tokenIndex: number;
+  line: number;
+  column: number;
+  channel: number;
+  text: string;
+  type: number;
+  start: number;
+  stop: number;
+}
+
+export interface SimpleParserRuleContext {
+  start: Token;
+
+  getText(): string;
+}