Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/plonk #47

Merged
merged 17 commits into from
Nov 7, 2024
Merged

Feature/plonk #47

merged 17 commits into from
Nov 7, 2024

Conversation

Hrom131
Copy link
Member

@Hrom131 Hrom131 commented Oct 29, 2024 •
edited
Loading

  • Since this PR suggests a bug fix, the relevant tests have been added.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@Hrom131 Hrom131 requested a review from Arvolear October 29, 2024 14:01
Arvolear
Arvolear reviewed Nov 2, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
Arvolear
Arvolear reviewed Nov 2, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
Arvolear
Arvolear reviewed Nov 2, 2024
View reviewed changes
src/index.ts Show resolved Hide resolved
Arvolear
Arvolear reviewed Nov 5, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@Arvolear Arvolear changed the base branch from master to dev November 7, 2024 11:43
Arvolear
Arvolear approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit d897461 into dev Nov 7, 2024
2 checks passed
@Arvolear Arvolear deleted the feature/plonk branch November 7, 2024 15:13
Arvolear added a commit that referenced this pull request Nov 14, 2024
@Arvolear @Hrom131 @mllwchrry
Plonk (#56)
c6aa722 
* Feature/plonk (#47)

* Add base plonk implementation

* Update doc comments

* Fix Reporter logs

* Add CircuitZKitBuilder class

* Small fixes

* Fix multiple ploring systems user flow

* Fix outdated subtask params

* added getPlonkConstraintsNumber function

* Add unit tests

* Update README file

* ptauId calculation fix

* fixed ptauId calculation for different proving systems

* quick readme fix

---------

Co-authored-by: mllwchrry <[email protected]>
Co-authored-by: Artem Chystiakov <[email protected]>

* Update zktype version

* Circom 2.2.0 (#53)

* updated latest supported Circom version to 2.2.0

* fixed unsupported versions test

* fixed platform-specific test

* restricted bus usage

* fixed error message

* update readme

* Fix rename logic for the cpp Makefile

* Update version

---------

Co-authored-by: Oleg Komendant <[email protected]>
Co-authored-by: mllwchrry <[email protected]>
Co-authored-by: Oleh Komendant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mllwchrry mllwchrry mllwchrry left review comments

@Arvolear Arvolear Arvolear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hrom131 @Arvolear @mllwchrry