-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circom 2.2.0 #53
Merged
Merged
Circom 2.2.0 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mllwchrry
commented
Nov 4, 2024
- Since this PR suggests a bug fix, the relevant tests have been added.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
Waiting for |
# Conflicts: # test/integration/tasks.test.ts
Hrom131
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Arvolear
added a commit
that referenced
this pull request
Nov 14, 2024
* Feature/plonk (#47) * Add base plonk implementation * Update doc comments * Fix Reporter logs * Add CircuitZKitBuilder class * Small fixes * Fix multiple ploring systems user flow * Fix outdated subtask params * added getPlonkConstraintsNumber function * Add unit tests * Update README file * ptauId calculation fix * fixed ptauId calculation for different proving systems * quick readme fix --------- Co-authored-by: mllwchrry <[email protected]> Co-authored-by: Artem Chystiakov <[email protected]> * Update zktype version * Circom 2.2.0 (#53) * updated latest supported Circom version to 2.2.0 * fixed unsupported versions test * fixed platform-specific test * restricted bus usage * fixed error message * update readme * Fix rename logic for the cpp Makefile * Update version --------- Co-authored-by: Oleg Komendant <[email protected]> Co-authored-by: mllwchrry <[email protected]> Co-authored-by: Oleh Komendant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.