Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Enhance Schema Definitions and Resolve Typo #64

Merged
merged 8 commits into from
Dec 26, 2024
Merged

Fix: Enhance Schema Definitions and Resolve Typo #64

merged 8 commits into from
Dec 26, 2024

Conversation

cypherpepe
Copy link
Contributor

This PR includes several updates:

  • Refactoring of compile-schemas.ts and CompilationProcessor.ts for better readability and maintainability.
  • Typo fix in CircomFilesResolver.ts for improved clarity.
  • Schema updates: Changed to use z.enum() for SignalTypeSchema and VisibilityTypeSchema.
  • Since this PR suggests a bug fix, the relevant tests have been added.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@Arvolear Arvolear requested a review from Hrom131 December 3, 2024 16:46
@cypherpepe
Copy link
Contributor Author

Hi! @Hrom131 Pls check my PR whenever you have a free moment.

@Hrom131
Copy link
Member

Hrom131 commented Dec 26, 2024

Hi @cypherpepe! Sorry for the delay in replying. Thank you for your contributions, please fix the comments above and we'll merge your PR

@cypherpepe
Copy link
Contributor Author

Hi @Hrom131 Done!

@cypherpepe cypherpepe requested a review from Hrom131 December 26, 2024 13:19
@cypherpepe
Copy link
Contributor Author

@Hrom131 Sorry, I misunderstood you. Done

Hrom131
Hrom131 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@Hrom131 Hrom131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hrom131 Hrom131 merged commit 686faa8 into dl-solarity:master Dec 26, 2024
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 26, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Solarity Contributor:

GitPOAP: 2024 Solarity Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hrom131 Hrom131 Hrom131 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cypherpepe @Hrom131