Draft: Use @safe and @trusted #840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanN7
reviewed
Aug 22, 2021
nordlow
changed the title
nordlow
changed the title
nordlow
changed the title
nordlow
changed the title
nordlow
changed the title
RazvanN7
reviewed
Aug 23, 2021
| { | ||
| } | ||
| else | ||
| int main(string[] args) | ||
| int main(string[] args) @trusted |
There was a problem hiding this comment.
What is the point of this change?
There was a problem hiding this comment.
shouldn't main be @safe instead of @trusted?
RazvanN7
reviewed
Aug 23, 2021
You're correct. I'll update the title. |
nordlow
changed the title
nordlow
changed the title
WebFreak001
reviewed
Aug 24, 2021
| @@ -81,7 +81,7 @@ protected: | |||
| override void visit(const T structDec) | |||
| { | |||
| inAggregate = true; | |||
| structDec.accept(this); | |||
| () @trusted { structDec.accept(this); } (); | |||
There was a problem hiding this comment.
I don't think this accept call can generally be @trusted, this should probably stay @system
| { | ||
| } | ||
| else | ||
| int main(string[] args) | ||
| int main(string[] args) @trusted |
There was a problem hiding this comment.
shouldn't main be @safe instead of @trusted?
nordlow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dlang-community/dsymbol#162.
Also inserts some @safe and @trusted mainly in dsymbol.
Using this in call to
in phobos passes without crash.