Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for ignored & templated unittests #861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WebFreak001
Copy link
Member

in DMD it seems to be a syntax error to have unittests in functions or
other unittests, but in libdparse it's allowed, so this dscanner check
adds a warning/error for that.

In the same check it implements a warning for unittests which are used
in templates. However as unittests in templates could be there just for
documentation, no warning is issued if annotated with a doc comment.

Mixin templates are not regarded as templates in this check as they
might be used for automatically generating unittests outside templates.

in DMD it seems to be a syntax error to have unittests in functions or
other unittests, but in libdparse it's allowed, so this dscanner check
adds a warning/error for that.

In the same check it implements a warning for unittests which are used
in templates. However as unittests in templates could be there just for
documentation, no warning is issued if annotated with a doc comment.

Mixin templates are not regarded as templates in this check as they
might be used for automatically generating unittests outside templates.
@rikkimax
Copy link
Contributor

In the same check it implements a warning for unittests which are used
in templates. However as unittests in templates could be there just for
documentation, no warning is issued if annotated with a doc comment.

Unittests should run in the binary that initialized them. If this isn't happening that is a bug.

That should probably be removed.

Error for this causing CI failures.

std/experimental/allocator/building_blocks/bitmapped_block.d
std/experimental/allocator/building_blocks/bitmapped_block.d(1370:17)[warn]: unittest blocks in templates may not be run and can only serve for documentation purpose. Document with a ddoc-comment or move unittest block out of template.
std/experimental/allocator/building_blocks/bitmapped_block.d(1645:17)[warn]: unittest blocks in templates may not be run and can only serve for documentation purpose. Document with a ddoc-comment or move unittest block out of template.
std/experimental/allocator/building_blocks/bitmapped_block.d(2176:13)[warn]: unittest blocks in templates may not be run and can only serve for documentation purpose. Document with a ddoc-comment or move unittest block out of template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants