Generator implements InputRange interface #5309
Conversation
…ement std.range.interfaces.InputRange without having to call inputRangeObject().
|
ping @wilzbach (or anybody who can review) |
|
ping @JackStouffer |
|
Ignored, so I close. Perhaps i'll try again some day. |
|
Sorry about this. I am currently juggling work and school so I only have time to review trivial PRs. Please understand that if a PR is in the queue and there are no blocking issues, it will get reviewed eventually. |
|
Well, it ain't ignored anymore, so I can reopen... It does not matter per se, i'm not in a hurry to get this in. I just don't want it to become one of those dead pr-s littering the queue. |
Codecov Report
@@ Coverage Diff @@
## master #5309 +/- ##
==========================================
+ Coverage 88.57% 88.57% +<.01%
==========================================
Files 117 117
Lines 77281 77311 +30
==========================================
+ Hits 68452 68482 +30
Misses 8829 8829
Continue to review full report at Codecov.
|
|
I have long since stopped checking this back often enough. If somebody made a comment on this it could well take weeks for me to notice. I close this, for now. |
|
@dukc if you still want to go ahead with this, I don't have merge privileges but I will review it and help push it through. If not, I will re-submit it on your behalf. |
|
@MetaLang I agree this should be resubmitted. I think it's worthwhile pursuing; I feel sorry that nobody had the time to review it. If only I had more free time... |
|
Reopened here: #5515 this time i'll notify on the forums before closing it, I promise. |
|
Please don't close good work. |
Reboot of #5194