Don't redirect the git push to /dev/null

If someone follows good release practice and keeps their ssh key for pushing to github password protected, and they also elect not to use a password agent for that ssh key, then you can't redirect the git push command to /dev/null or else they won't get asked their password on push and instead all pushes will always fail. Signed-off-by: Doug Ledford <[email protected]>
dledford · Mar 25, 2017 · 3c146fd · 3c146fd
1 parent 60a4f46
commit 3c146fd
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/github-release.rb b/lib/github-release.rb
@@ -107,9 +107,10 @@ def git_config(item, default = nil)
 	end
 
 	def create_release(tag)
-		print "Creating a release for #{tag}..."
-		system("git push #{remote_name} tag #{tag} >/dev/null 2>&1")
+		puts "Pushing to #{remote_name}..."
+		system("git push #{remote_name} tag #{tag}")
 
+		print "Creating a release for #{tag}..."
 		msg = `git tag -l -n1000 '#{tag}'`
 
 		# Ye ghods is is a horrific format to parse