Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing interface declaration for IMagickImage.ToBase64 #1639

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: add missing interface declaration for IMagickImage.ToBase64 #1639

merged 1 commit into from
May 24, 2024

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented May 24, 2024

Description

👋

This PR add one variant of ToBase64 to the interface. Implementation is already there, tests too.

Regards.

dlemstra
dlemstra approved these changes May 24, 2024
View reviewed changes
Copy link
Owner

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. And it also looks like I forgot to add the interface declaration and method implementation for this in the MagickImageCollection.

@dlemstra dlemstra merged commit fc3561f into dlemstra:main May 24, 2024
26 checks passed
@Gounlaf
Copy link
Contributor Author

Gounlaf commented May 24, 2024

And it also looks like I forgot to add the interface declaration and method implementation for this in the MagickImageCollection.

I will make a PR for it.

@Gounlaf Gounlaf deleted the fix-imagickimage-tobase64 branch May 25, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlemstra dlemstra dlemstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gounlaf @dlemstra