Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opti: use a HashSet instead of List #1642

Merged
merged 1 commit into from
May 25, 2024
Merged

opti: use a HashSet instead of List #1642

merged 1 commit into from
May 25, 2024

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented May 25, 2024

Description

👋

It avoids looping + contains check.

Regards.

@Gounlaf
opti: use a HashSet instead of List
ac4feed 
Avoid looping & Contains check.

Signed-off-by: Florian Levis <[email protected]>
dlemstra
dlemstra approved these changes May 25, 2024
View reviewed changes
Copy link
Owner

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these improvements! Really appreciate all the work you are doing.

@dlemstra dlemstra merged commit 6b77f17 into dlemstra:main May 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlemstra dlemstra dlemstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gounlaf @dlemstra