Add PngWriteDefines to Magick.NET #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This enum defines flags for specifying PNG chunks to include or exclude. - The flags are based on the documentation found at https://imagemagick.org/script/command-line-options.php#strip - Includes chunks such as bKGD, cHRM, EXIF, gAMA, iCCP, iTXt, sRGB, tEXt, zCCP, zTXt, and date.
rubenscordeirobr
changed the title
rubenscordeirobr
changed the title
…PNG specification naming conventions.
…arnings - Updated XML comments for PreserveColorMap property to resolve SA1623. - Removed an empty line to resolve SA1507.
- Added copyright notice to the header that was previously missing. - Added `#if NETSTANDARD == false` to hide `[Flags]` attribute for non-.NET Standard frameworks. This resolves build failures on Windows ARM64 processors. - Added justification to SuppressMessage in PngChunkFlags "The lowercase names are consistent with the naming conventions of PNG chunk types as defined in the PNG specification."
- Removed bitwise shift operators and used explicit int values for flag definitions.
- Resolved StyleCop error SA1137: Elements should have the same indentation.
dlemstra
reviewed
Jun 28, 2024
tests/Magick.NET.Tests/Formats/Png/PngWriteDefinesTests/TheBitDepthProperty.cs
Outdated
Show resolved
Hide resolved
tests/Magick.NET.Tests/Formats/Png/PngWriteDefinesTests/TheBitDepthProperty.cs
Outdated
Show resolved
Hide resolved
tests/Magick.NET.Tests/Formats/Png/PngWriteDefinesTests/ThePreserveColorMapPropety.cs
Outdated
Show resolved
Hide resolved
- Alphabetical ordering for CompressionLevel and CompressionFilter. - Converted CompressionFilter and CompressionStrategy to numeric values.
- This option is only used when reading a PNG. - Removed TheIncludeChunksProperty class from PngWriteDefinesTests
…roperty. - Updated the class name to follow the naming convention for property test classes.
…nNull PngWriteDefinesTests. - TheBitDepthProperty - TheColorTypeProperty - TheCompressionFilterProperty - TheExcludeChunksProperty - TheCompressionStrategyProperty
- Updated tests to use numeric values for properties in - TheColorTypeProperty - TheCompressionFilterProperty - ThreCompressionStrategyProperty
…iteDefinesTests..
…ue in ThePreserveColorMapPropety class test
|
Please let me know if there's anything else to do before merging this pull request, and I'll adjust it as necessary. |
|
I thought this was still work in progress because |
|
In the PngWriteDefines class, I noticed that the property ColorType is of the enum type ImageMagick.ColorType. However, I observed a difference between the numeric values of ImageMagick.ColorType and the required values for png:color-type. For example, ImageMagick.ColorType.Grayscale equals 2, but png:color-type requires a value of 0 for Grayscale. To handle this, I created a PngColorType enum to correctly map and convert these values before sending them to ImageMagick. Although this solution works, I believe it might be more efficient to change the type of the ColorType property directly to PngColorType for better clarity and accuracy. Please let me know your thoughts on this change. |
dlemstra
reviewed
Jul 4, 2024
tests/Magick.NET.Tests/Formats/Png/PngWriteDefinesTests/ThreCompressionStrategyProperty.cs
Outdated
Show resolved
Hide resolved
tests/Magick.NET.Tests/Formats/Png/PngWriteDefinesTests/TheColorTypeProperty.cs
Show resolved
Hide resolved
- Corrected the class name from `ThreCompressionStrategyProperty` to `TheCompressionStrategyProperty`
…removed due to a misunderstanding. - Revert "Removed IncludeChunks property in PngWriteDefines." This reverts commit 2584741ac.
- Replaced the PngColorType enumeration with direct integer values for better performance.
dlemstra
reviewed
Jul 13, 2024
tests/Magick.NET.Tests/Formats/Png/PngWriteDefinesTests/TheColorTypeProperty.cs
Outdated
Show resolved
Hide resolved
- ShouldThrowExceptionWhenColorTypeIsOptimize to check for unsupported ColorType.Optimize. - ShouldThrowExceptionWhenColorTypeIsInvalid to check for unsupported integer values as ColorType.
dlemstra
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the PngWriteDefines class to the Magick.NET project. The PngWriteDefines class includes several enums (PngChunkFlags, PngCompressionFilter, PngCompressionStrategy),
Changes Proposed:
Added the PngWriteDefines class with the following properties:
BitDepth - Specifies the bit depth for the PNG image.
ColorType - Specifies the color type for the PNG image.
CompressionFilter - Specifies the compression filter for the PNG image using the PngCompressionFilter enum.
CompressionLevel - Specifies the compression level for the PNG image.
CompressionStrategy - Specifies the compression strategy for the PNG image using the PngCompressionStrategy enum.
ExcludeChunks - Specifies the chunks to be excluded using the PngChunkFlags enum.
IncludeChunks - Specifies the chunks to be included using the PngChunkFlags enum.
IgnoreCrc - Indicates whether the PNG decoder should ignore the CRC.
PreserveICCP - Indicates whether to preserve the ICC profile.
PreserveColormap - Indicates whether to preserve the colormap.