Small search handler improvement #143

sclassen · 2019-10-21T21:47:32Z

PR Checklist

There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open an issue first and wait for approval before working on it.
The code follows the Google Java Style Guide.
JavaDoc is added / changed for public methods.
An example of the new feature is added to the demos.
Documentation of the feature is included in the README.
Tests for the changes are included.

What is the current behavior?

Behavior is unchanged

What is the new behavior?

There is a slight performance gain because of short cutting in case the category or group description matches the search text

Is related to #94

Breaking Change:

none

this is a minor speed improvement as it will not dive into groups or settings if a higher level already matches the searchText

preferencesfx/src/main/java/com/dlsc/preferencesfx/util/SearchHandler.java

sclassen · 2019-10-21T22:01:32Z

@martinfrancois
Maybe you understand what exactly codeclimate means. If I remove the "unused" parameters the code does no longer compile 🙄

sclassen · 2019-10-21T22:15:10Z

Found it: https://jira.sonarsource.com/browse/SONARJAVA-2115
It is fixed in SonarJava 5.0 which was released in Dez 2017.
But it looks like codeclimate still uses 4.14 (https://docs.codeclimate.com/docs/sonar-java)

sclassen added 2 commits October 21, 2019 23:42

refactor filterPredicate to allow shortcutting in case of early match

be0e590

this is a minor speed improvement as it will not dive into groups or settings if a higher level already matches the searchText

make use of helper function isNullOrEmpty()

d2ec95b

codeclimate bot reviewed Oct 21, 2019

View reviewed changes

rename field searchText -> searchTextProperty

56c12e0

dlemmermann merged commit 01ae1fd into dlsc-software-consulting-gmbh:master Aug 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Small search handler improvement #143

Small search handler improvement #143

sclassen commented Oct 21, 2019

sclassen commented Oct 21, 2019

sclassen commented Oct 21, 2019 •

edited

Loading

Small search handler improvement #143

Small search handler improvement #143

Conversation

sclassen commented Oct 21, 2019

PR Checklist

What is the current behavior?

What is the new behavior?

Breaking Change:

sclassen commented Oct 21, 2019

sclassen commented Oct 21, 2019 • edited Loading

sclassen commented Oct 21, 2019 •

edited

Loading