Skip to content

Commit

Permalink
post devel merge fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sh-rp committed Apr 25, 2024
1 parent 4d5db26 commit 13f4b1c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion dlt/common/destination/capabilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ class DestinationCapabilitiesContext(ContainerInjectableContext):
insert_values_writer_type: str = "default"
supports_multiple_statements: bool = True
supports_clone_table: bool = False
scd2_high_timestamp: pendulum.DateTime = HIGH_TS
"""High timestamp used to indicate active records in `scd2` merge strategy."""

"""Destination supports CREATE TABLE ... CLONE ... statements"""
Expand Down
1 change: 0 additions & 1 deletion dlt/destinations/impl/clickhouse/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def capabilities() -> DestinationCapabilitiesContext:
# https://stackoverflow.com/questions/68358686/what-is-the-maximum-length-of-a-column-in-clickhouse-can-it-be-modified
caps.max_identifier_length = 255
caps.max_column_identifier_length = 255
caps.scd2_high_timestamp = pendulum.datetime(2299, 12, 31) # this is the max datetime...

# ClickHouse has no max `String` type length.
caps.max_text_data_type_length = sys.maxsize
Expand Down
2 changes: 1 addition & 1 deletion tests/load/pipeline/test_scd2.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def assert_records_as_set(actual: List[Dict[str, Any]], expected: List[Dict[str,
for dconf in destinations_configs(default_sql_configs=True, supports_merge=True)
]
+ [
(dconf, True, None, pendulum.DateTime(3234, 12, 31, 22, 2, 59)) # arbitrary timestamp
(dconf, True, None, pendulum.DateTime(2099, 12, 31, 22, 2, 59)) # arbitrary timestamp
for dconf in destinations_configs(default_sql_configs=True, supports_merge=True)
]
+ [ # test nested columns and validity column name configuration only for postgres and duckdb
Expand Down

0 comments on commit 13f4b1c

Please sign in to comment.