fix apply hints (#612)

* fix apply hints * move column fixing into helper function
dlt-hub · Sep 11, 2023 · 171bf15 · 171bf15
1 parent e851156
commit 171bf15
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/dlt/extract/utils.py b/dlt/extract/utils.py
@@ -31,6 +31,9 @@ def ensure_table_schema_columns(columns: TAnySchemaColumns) -> TTableSchemaColum
     """
     if isinstance(columns, C_Mapping):
         # Assume dict is already in the correct format
+        # but ensure the name key is set correctly
+        for name, column in columns.items():
+            column["name"] = name
         return columns
     elif isinstance(columns, Sequence):
         # Assume list of columns

diff --git a/tests/extract/test_decorators.py b/tests/extract/test_decorators.py
@@ -194,6 +194,8 @@ def get_users():
     t = r.table_schema()
 
     assert t["columns"]["tags"]["x-second-extra"] == "x-second-annotation"
+    # make sure column name was set
+    assert t["columns"]["tags"]["name"] == "tags"
 
 
 def test_columns_from_pydantic() -> None: