uses datetime as load_package_timestamp

dlt-hub · May 7, 2024 · 3af94e4 · 3af94e4
1 parent dc6f1ba
commit 3af94e4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/dlt/destinations/path_utils.py b/dlt/destinations/path_utils.py
@@ -98,7 +98,7 @@ def get_unused_placeholders(
 
 def prepare_datetime_params(
     current_datetime: Optional[pendulum.DateTime] = None,
-    load_package_timestamp: Optional[str] = None,
+    load_package_timestamp: Optional[pendulum.DateTime] = None,
 ) -> Dict[str, str]:
     params: Dict[str, str] = {}
     current_timestamp: pendulum.DateTime = None
@@ -214,7 +214,7 @@ def create_path(
     file_name: str,
     schema_name: str,
     load_id: str,
-    load_package_timestamp: Optional[str] = None,
+    load_package_timestamp: Optional[pendulum.DateTime] = None,
     current_datetime: Optional[TCurrentDateTime] = None,
     extra_placeholders: Optional[Dict[str, Any]] = None,
 ) -> str:

diff --git a/tests/destinations/test_path_utils.py b/tests/destinations/test_path_utils.py
@@ -314,7 +314,7 @@ def test_layout_validity(
         return_value=job_info,
     )
 
-    now_timestamp = frozen_datetime.to_iso8601_string()
+    now_timestamp = frozen_datetime
     if is_valid:
         path = create_path(
             layout,
@@ -404,7 +404,7 @@ def test_create_path_uses_provided_load_package_timestamp(test_load: TestLoad) -
         "{schema_name}/{table_name}/{load_id}.{file_id}.{timestamp}.{ext}",
         schema_name="schema_name",
         load_id=load_id,
-        load_package_timestamp=now.to_iso8601_string(),
+        load_package_timestamp=now,
         file_name=job_info.file_name(),
     )
 
@@ -425,7 +425,7 @@ def test_create_path_resolves_current_datetime(test_load: TestLoad) -> None:
     load_id, job_info = test_load
     now = pendulum.now()
     timestamp = int(now.timestamp())
-    now_timestamp = now.to_iso8601_string()
+    now_timestamp = now
     calls = 0
 
     def current_datetime_callback():
@@ -508,7 +508,7 @@ def test_create_path_uses_load_package_timestamp_as_current_datetime(
     load_id, job_info = test_load
     now = pendulum.now()
     timestamp = int(now.timestamp())
-    now_timestamp = now.to_iso8601_string()
+    now_timestamp = now
     logger_spy = mocker.spy(logger, "info")
     ensure_pendulum_datetime_spy = mocker.spy(
         dlt.destinations.path_utils, "ensure_pendulum_datetime"
@@ -557,7 +557,7 @@ def inc(self, *args, **kwargs):
     }
     now = pendulum.now()
     timestamp = int(now.timestamp())
-    now_timestamp = now.to_iso8601_string()
+    now_timestamp = now
     created_path = create_path(
         "{schema_name}/{table_name}/{callable_1}-{otter}/{load_id}.{file_id}.{timestamp}.{ext}",
         schema_name="schema_name",