Skip to content

Commit

Permalink
carry over schema settings on update
Browse files Browse the repository at this point in the history
  • Loading branch information
sh-rp committed Sep 6, 2023
1 parent 3f07127 commit 6308369
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion dlt/extract/decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ def source(
Returns:
`DltSource` instance
"""

if name and schema:
raise ArgumentsOverloadException("'name' has no effect when `schema` argument is present", source.__name__)

Expand Down
1 change: 1 addition & 0 deletions dlt/pipeline/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,7 @@ def _extract_source(self, storage: ExtractorStorage, source: DltSource, max_para
# note we are not merging props like max nesting or column propagation
for table in source_schema.data_tables(include_incomplete=True):
pipeline_schema.update_schema(pipeline_schema.normalize_table_identifiers(table))
pipeline_schema._settings["schema_evolution_settings"] = source_schema._settings.get("schema_evolution_settings")

return extract_id

Expand Down

0 comments on commit 6308369

Please sign in to comment.