Skip to content

Commit

Permalink
make secret name when dropping optional
Browse files Browse the repository at this point in the history
  • Loading branch information
sh-rp committed Oct 7, 2024
1 parent 631d50b commit 8e2e37c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dlt/destinations/impl/filesystem/sql_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def _create_default_secret_name(self) -> str:
escaped_bucket_name = regex.sub("", self.fs_client.config.bucket_url.lower())
return f"secret_{escaped_bucket_name}"

def drop_authentication(self, secret_name: str) -> None:
def drop_authentication(self, secret_name: str = None) -> None:
if not secret_name:
secret_name = self._create_default_secret_name()
self._conn.sql(f"DROP PERSISTENT SECRET {secret_name}")
Expand Down

0 comments on commit 8e2e37c

Please sign in to comment.