Skip to content

Commit

Permalink
remove natural_key remnants
Browse files Browse the repository at this point in the history
  • Loading branch information
jorritsandbrink committed Sep 24, 2024
1 parent 5888a07 commit 8ecf7c6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion dlt/common/schema/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ class TScd2StrategyDict(TMergeDispositionDict, total=False):
boundary_timestamp: Optional[TAnyDateTime]
row_version_column_name: Optional[str]
retire_absent_rows: Optional[bool]
natural_key: Optional[str]


TWriteDispositionConfig = Union[
Expand Down
6 changes: 0 additions & 6 deletions dlt/extract/hints.py
Original file line number Diff line number Diff line change
Expand Up @@ -460,12 +460,6 @@ def _merge_merge_disposition_dict(dict_: Dict[str, Any]) -> None:
dict_["x-boundary-timestamp"] = md_dict["boundary_timestamp"]
if "retire_absent_rows" in md_dict:
dict_["x-retire-absent-rows"] = md_dict["retire_absent_rows"]
if "natural_key" in md_dict:
nk = md_dict["natural_key"]
if nk in dict_["columns"]:
dict_["columns"][nk]["x-natural-key"] = True
else:
dict_["columns"][nk] = {"name": nk, "x-natural-key": True}
if md_dict.get("validity_column_names") is None:
from_, to = DEFAULT_VALIDITY_COLUMN_NAMES
else:
Expand Down

0 comments on commit 8ecf7c6

Please sign in to comment.