Skip to content

Commit

Permalink
adds naming convention to restore state tests, make them essential
Browse files Browse the repository at this point in the history
  • Loading branch information
rudolfix committed Jun 11, 2024
1 parent dea9669 commit b1e2b09
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tests/load/pipeline/test_restore_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ def test_silently_skip_on_invalid_credentials(
destination_config.setup_pipeline(pipeline_name=pipeline_name, dataset_name=dataset_name)


@pytest.mark.essential
@pytest.mark.parametrize(
"destination_config",
destinations_configs(
Expand All @@ -193,7 +194,9 @@ def test_silently_skip_on_invalid_credentials(
ids=lambda x: x.name,
)
@pytest.mark.parametrize("use_single_dataset", [True, False])
@pytest.mark.parametrize("naming_convention", ["sql_upper", "snake_case"])
@pytest.mark.parametrize(
"naming_convention", ["tests.common.cases.normalizers.title_case", "snake_case"]
)
def test_get_schemas_from_destination(
destination_config: DestinationTestConfiguration,
use_single_dataset: bool,
Expand Down Expand Up @@ -276,14 +279,17 @@ def _make_dn_name(schema_name: str) -> str:
assert len(restored_schemas) == 3


@pytest.mark.essential
@pytest.mark.parametrize(
"destination_config",
destinations_configs(
default_sql_configs=True, default_vector_configs=True, all_buckets_filesystem_configs=True
),
ids=lambda x: x.name,
)
@pytest.mark.parametrize("naming_convention", ["sql_upper"])
@pytest.mark.parametrize(
"naming_convention", ["tests.common.cases.normalizers.title_case", "snake_case", "sql_upper"]
)
def test_restore_state_pipeline(
destination_config: DestinationTestConfiguration, naming_convention: str
) -> None:
Expand Down

0 comments on commit b1e2b09

Please sign in to comment.