Skip to content

Commit

Permalink
Set compression parameter for local #1055
Browse files Browse the repository at this point in the history
Signed-off-by: Marcel Coetzee <[email protected]>
  • Loading branch information
Pipboyguy committed Apr 9, 2024
1 parent 7fe0a91 commit e30ce6d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dlt/destinations/impl/clickhouse/clickhouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def __init__(
"allow_experimental_lightweight_delete": 1,
"allow_experimental_object_type": 1,
},
# compression=None if compression == "none" else compression,
compression=None if compression == "none" else compression,
)
except clickhouse_connect.driver.exceptions.Error as e:
raise LoadJobTerminalException(
Expand Down
2 changes: 1 addition & 1 deletion dlt/destinations/impl/clickhouse/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def to_url(self) -> URL:
class ClickHouseClientConfiguration(DestinationClientDwhWithStagingConfiguration):
destination_type: Final[str] = "clickhouse" # type: ignore[misc]
credentials: ClickHouseCredentials # type: ignore
dataset_name: Final[str] = "dlt" # type: ignore
dataset_name: Final[str] = "" # type: ignore
"""dataset name in the destination to load data to, for schemas that are not default schema, it is used as dataset prefix"""

# Primary key columns are used to build a sparse primary index which allows for efficient data retrieval,
Expand Down

0 comments on commit e30ce6d

Please sign in to comment.