Skip to content

Commit

Permalink
Change raise_for_status default to False
Browse files Browse the repository at this point in the history
  • Loading branch information
burnash committed Mar 4, 2024
1 parent fc34dd0 commit e40579b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dlt/sources/helpers/requests/retry.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def __init__(
Union[TimedeltaSeconds, Tuple[TimedeltaSeconds, TimedeltaSeconds]]
] = DEFAULT_TIMEOUT,
max_connections: int = 50,
raise_for_status: bool = True,
raise_for_status: bool = False,
status_codes: Sequence[int] = DEFAULT_RETRY_STATUS,
exceptions: Sequence[Type[Exception]] = DEFAULT_RETRY_EXCEPTIONS,
request_max_attempts: int = RunConfiguration.request_max_attempts,
Expand Down
2 changes: 1 addition & 1 deletion dlt/sources/helpers/requests/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(
timeout: Optional[
Union[TimedeltaSeconds, Tuple[TimedeltaSeconds, TimedeltaSeconds]]
] = DEFAULT_TIMEOUT,
raise_for_status: bool = True,
raise_for_status: bool = False,
) -> None:
super().__init__()
self.timeout = _timeout_to_seconds(timeout)
Expand Down

0 comments on commit e40579b

Please sign in to comment.