Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement missing arrow and data contracts tests #787

Closed
1 of 9 tasks
rudolfix opened this issue Nov 23, 2023 · 1 comment · Fixed by #896
Closed
1 of 9 tasks

implement missing arrow and data contracts tests #787

rudolfix opened this issue Nov 23, 2023 · 1 comment · Fixed by #896
Assignees
Labels
tech-debt Leftovers from previous sprint that should be fixed over time

Comments

@rudolfix
Copy link
Collaborator

rudolfix commented Nov 23, 2023

Tasks

  • - test basic pyarrow lib
  • - test pyarrow normalize
  • - define columns and then load arrow table with incorrect order
  • - fix _dlt_load_id added only if needed
  • - test discard value and discard row in nested json: discard row in child table that has another child table should discard data from descendants
  • - test removal of x-normalizer tags (also when {})
  • - pydantic nested model test
  • - allow Annotated when synthesizing models
  • - test freeze exception with Pydantic
@rudolfix rudolfix added the devel label Nov 23, 2023
@rudolfix rudolfix self-assigned this Nov 23, 2023
@rudolfix rudolfix moved this from Todo to In Progress in dlt core library Nov 23, 2023
@rudolfix rudolfix moved this from In Progress to Planned in dlt core library Nov 24, 2023
@rudolfix rudolfix added tech-debt Leftovers from previous sprint that should be fixed over time and removed devel labels Dec 23, 2023
@sh-rp sh-rp self-assigned this Jan 16, 2024
@sh-rp sh-rp moved this from Planned to In Progress in dlt core library Jan 16, 2024
@sh-rp
Copy link
Collaborator

sh-rp commented Jan 16, 2024

Questions:

  • What should we test with nested models on pydantic? Right now it is not implemented, so maybe this is the task?

@sh-rp sh-rp mentioned this issue Jan 16, 2024
8 tasks
@sh-rp sh-rp linked a pull request Jan 22, 2024 that will close this issue
8 tasks
@rudolfix rudolfix moved this from In Progress to Planned in dlt core library Mar 4, 2024
@rudolfix rudolfix moved this from Planned to In Progress in dlt core library Mar 25, 2024
@rudolfix rudolfix assigned rudolfix and unassigned rudolfix and sh-rp Apr 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in dlt core library Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Leftovers from previous sprint that should be fixed over time
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants