Add some missing tests #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sh-rp
force-pushed
the
d#/787-missing-tests
branch
3 times, most recently
from
60f9097 to
31b5ae8
Compare
|
@rudolfix questions:
|
sh-rp
force-pushed
the
d#/787-missing-tests
branch
from
a03fc46 to
5adf9c5
Compare
9 tasks
sh-rp
force-pushed
the
d#/787-missing-tests
branch
from
9c14c69 to
e183b1b
Compare
rudolfix
requested changes
Apr 17, 2024
| {"col1": 1}, | ||
| ] | ||
| ) | ||
| columns = [new_column("_dlt_something", "bigint"), new_column("col2", "text")] |
There was a problem hiding this comment.
because of SCD2 only _dlt_versions and loads are removed. other columns may be added. check the normalize and pls fix the test
tests/normalize/test_normalize.py
Outdated
| @@ -708,3 +709,32 @@ def assert_timestamp_data_type(load_storage: LoadStorage, data_type: TDataType) | |||
| event_schema = load_storage.normalized_packages.load_schema(loads[0]) | |||
| # in raw normalize timestamp column must not be coerced to timestamp | |||
| assert event_schema.get_table_columns("event")["timestamp"]["data_type"] == data_type | |||
|
|
|||
|
|
|||
| def test_removal_of_normalizer_schema_section(raw_normalize: Normalize) -> None: | |||
There was a problem hiding this comment.
so this test must be a little extended.
- we remove evolove-columns-once
- but we add
seen-datato all tables that had data items (see shcema utils: has_table_seen_data)
this is a good test, needs to be upgraded
sh-rp
added
ci full
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
original ticket: #787