-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import missing pyarrow compute for transforms on arrowitems #1010
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dlt/extract/incremental/transform.py
Outdated
@@ -11,6 +11,11 @@ | |||
except ModuleNotFoundError: | |||
np = None | |||
|
|||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add this to libs/pyarrow
together with other imports
I have also fixed a few other imports, i am just not 100% certain if maybe the user is not getting the right error messages in some cases, especially where I have this grouped import. lmk |
@sh-rp, just FYI regarding error handling:
I just ran into this, the error says now:
but the error solves when installing:
It's a bit confusing now. Maybe should be added to the docs somewhere. Full stack:
|
@sh-rp SQLAlchemy was removed from our dependencies. this does not come out in the tests because most probably one of extra or dev deps install panda. what is wrong
|
Description
Adding an incremental for loads with arrowitems fails on a missing compute property. This PR fixes this.