Upgrades to streamlit app #1036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sultaniman
commented
Feb 29, 2024
| ) | ||
|
|
||
|
|
||
| maybe_install_streamlit() |
There was a problem hiding this comment.
I will remove this and will call it in streamlit_app/init.py
rudolfix
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Let's review UI together! First take:
- the sidebar should contain the most important information like pipeline name, destination etc. maybe last load if trace is present
- I do not want to distribute images with the library
- OR we should distribute the streamlit app as dlt extra: we extract this app as seprate dependency
otherwise I'm so happy we are pushing that forward
rudolfix
requested changes
Feb 29, 2024
| globals()[package] = importlib.import_module(package) | ||
|
|
||
|
|
||
| def query_yes_no(question, default="yes"): |
There was a problem hiding this comment.
what's wrong with current echo.py and clikck library we use. this should IMO work
There was a problem hiding this comment.
@rudolfix I will use dlt.echo 🙂 thanks for reference
|
Closing this in favor of #1060 because I decided to split automatic dependency installation utilities in the separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades our streamlit app #459 which is launched when
dlt pipeline PIPELINE_NAME showcommand is called.It also includes better prompt to detect and install streamlit and additional packages if it is missing.