Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve initial_value for incremental from config #1058

Closed
wants to merge 1 commit into from

Conversation

sultaniman
Copy link
Contributor

This PR will address the issue #1034 where it is not possible to fetch initial_value from config.toml

@dlt.resource(write_disposition="merge", table_name="referrals", primary_key="id")
def referrals_resource(
    api_secret_key=dlt.secrets.value,
    createdAfter=dlt.sources.incremental(
        "created",
        # BUG: cannot read this initial_value from config file
        initial_value=dlt.config.value,
        last_value_func=last_value_func,
    ),
    campaign_ids=dlt.config.value,
    schema_contract=SCHEMA_CONTRACT
):

@sultaniman sultaniman self-assigned this Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 08f3172
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65e855e61f9cc1000824fc60

@rudolfix
Copy link
Collaborator

@sultaniman as discussed - this needs docs update where we show how to configure incremental. so close this or repurpose the PR

@sultaniman
Copy link
Contributor Author

@rudolfix thanks for reminding it, I created a documentation ticket for this #1077, also @dat-a-man has a PR #1059 I will likely prepare an update for his PR and send it over.

@sultaniman sultaniman closed this Mar 13, 2024
@sultaniman sultaniman deleted the issue-1034 branch March 13, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants