-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Deploy dlt on dagster #1086
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-dagster.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-dagster.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-dagster.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-dagster.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the writeup is good. Without some code it seems like I get nothing out of the page, so added some snippets.
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-dagster.md
Outdated
Show resolved
Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-dagster.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-dagster.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging
Adding import DltResource in the Definition script.
Removing DltResource args
Changing resource name from DltResource to DltPipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting Passed.
Description
Adding documentation on deploying dlt on Dagster
Related Issues
Additional Context