Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: deploy with Kestra #1087

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Docs: deploy with Kestra #1087

merged 7 commits into from
Mar 25, 2024

Conversation

dat-a-man
Copy link
Collaborator

Description

Added documentation deploy with Kestra

Related Issues

  • Fixes #...
  • Closes #...
  • Resolves #...

Additional Context

@dat-a-man dat-a-man requested a review from zem360 March 13, 2024 06:07
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 5302b2d
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65fd1e72bf10f6000812f773
😎 Deploy Preview https://deploy-preview-1087--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

burnash
burnash previously requested changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please see my comments. I believe the content benefits from less redundant parts.

docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-kestra.md Outdated Show resolved Hide resolved
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-kestra.md Outdated Show resolved Hide resolved
sh-rp
sh-rp reviewed Mar 15, 2024
View reviewed changes
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-kestra.md Outdated
1. Configure Docker compose File: Edit the downloaded Docker compose file to link the `.env` file
for environment variables.

```python
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be marked as ```yaml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

@dat-a-man dat-a-man added the documentation Improvements or additions to documentation label Mar 18, 2024
zem360
zem360 reviewed Mar 20, 2024
View reviewed changes
docs/website/docs/walkthroughs/deploy-a-pipeline/deploy-with-kestra.md Outdated

## Building Data Pipelines with `dlt`

**`dlt`** is an open-source Python library that allows you to declaratively load data sources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the sentences short:

dlt is an open-source Python library that allows you to declaratively load data sources
into well-structured tables or datasets. It does this through automatic schema inference and evolution.

The library simplifies building data pipeline . . .

zem360
zem360 reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@zem360 zem360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments mostly related to grammar and sentence structure.

zem360
zem360 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@zem360 zem360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dat-a-man This is good to merge.

@zem360 zem360 dismissed burnash’s stale review March 25, 2024 14:32

Changes Implemented

@zem360 zem360 merged commit d5aab24 into devel Mar 25, 2024
44 checks passed
@zem360 zem360 deleted the docs/deploy-dlt-with-kestra branch March 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh-rp sh-rp sh-rp left review comments

@zem360 zem360 zem360 approved these changes

@burnash burnash burnash left review comments

Assignees

@zem360 zem360

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dat-a-man @burnash @sh-rp @zem360