regular initializers for credentials #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
…nings on inconsistent settings
…al init for credentials
rudolfix
force-pushed
the
rfix/regular-initializers-for-credentials
branch
from
5fd135e to
dba0114
Compare
|
@sh-rp please look at this, there's (small) impact on destinations that use ConnectionStringCredentials ( are dremio/clickhouse using it?) |
sh-rp
approved these changes
Mar 25, 2024
sultaniman
reviewed
Mar 26, 2024
| is_max_text_data_type_length_in_bytes: bool | ||
| supports_transactions: bool | ||
| supports_ddl_transactions: bool | ||
| preferred_loader_file_format: TLoaderFileFormat = None |
There was a problem hiding this comment.
maybe all of them should've been annotated with Optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dataclass_transformto autogenerate typings for BaseConfiguration #858__init__method forCredentialsConfiguration__init__that we wrote for type checking as they are now generated