Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enabled listing for docs snippets #1143

Merged
merged 3 commits into from
Mar 25, 2024
Merged

docs: enabled listing for docs snippets #1143

merged 3 commits into from
Mar 25, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Mar 25, 2024

Description

Enables snippets linting for the docs snippets

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit d88b10b
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/660148088009b800082b8d9f
😎 Deploy Preview https://deploy-preview-1143--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp sh-rp marked this pull request as ready for review March 25, 2024 09:46
@sh-rp sh-rp linked an issue Mar 25, 2024 that may be closed by this pull request
@sh-rp sh-rp requested a review from AstrakhantsevaAA March 25, 2024 10:20
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
One optional suggestion: use glob

if file.endswith(".md"):
markdown_files.append(os.path.join(path, file))
if verbose:
fmt.echo(f"Discovered {os.path.join(path, file)}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you use glob?

glob.glob(f'{BLOG_DIR}/**/*.md', recursive=True)

https://docs.python.org/3/library/glob.html

@sh-rp sh-rp merged commit cf3ac9f into devel Mar 25, 2024
44 checks passed
@sh-rp sh-rp deleted the d#/fix_blog_snippets branch March 25, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Parse, Lint and Fix Blog Snippets
2 participants