Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change formatting line length to 88 chars #1180

Closed
wants to merge 2 commits into from

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Apr 3, 2024

Description

This PR reduces the code's line length, not reaching the PEP 8-suggested 79 characters but still enhancing readability:

  • shorter lines improve readability by fitting within the natural field of vision, reducing the need to scan long lines.
  • this also imporoves side-by-side comparison & beneficial for code reviews where code is displayed in adjacent columns.

@burnash burnash requested review from rudolfix, sh-rp and sultaniman April 3, 2024 10:53
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 0e7769e
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/660dc0db533e9f00081ec2ac

@burnash burnash force-pushed the enh/change_formatting_line_length branch from 3bdb7d8 to 868121c Compare April 3, 2024 16:27
@burnash burnash self-assigned this Apr 3, 2024
@burnash burnash force-pushed the enh/change_formatting_line_length branch from b093c50 to 0e7769e Compare April 3, 2024 20:49
@rudolfix
Copy link
Collaborator

rudolfix commented Apr 3, 2024

tbh. I have the opposite opinion on line length. 100 characters we have now is already a good compromise, I'd rather go for 200 characters if not other people preferences

@sh-rp
Copy link
Collaborator

sh-rp commented Apr 24, 2024

Close this for now, let's discuss this when migrating to ruff.

@sh-rp sh-rp closed this Apr 24, 2024
@rudolfix rudolfix deleted the enh/change_formatting_line_length branch May 20, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants