Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Extend layout placeholder params for filesystem destinations #1220

Merged
merged 22 commits into from
Apr 17, 2024

Conversation

sultaniman
Copy link
Contributor

This PR adds documentation for #1182

@sultaniman sultaniman added documentation Improvements or additions to documentation community This issue came from slack community workspace labels Apr 15, 2024
@sultaniman sultaniman self-assigned this Apr 15, 2024
@sultaniman sultaniman requested a review from VioletM April 15, 2024 11:24
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 394d7be
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/661eb0aaaea42a00082e8a1f
😎 Deploy Preview https://deploy-preview-1220--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sultaniman sultaniman changed the title Extend layout placeholder params for filesystem destinations Docs: Extend layout placeholder params for filesystem destinations Apr 15, 2024
@sultaniman sultaniman requested a review from rudolfix April 15, 2024 12:29
@sultaniman sultaniman added the destination Issue related to new destinations label Apr 15, 2024
@sultaniman sultaniman requested a review from VioletM April 15, 2024 15:15
@sultaniman sultaniman merged commit 0dde058 into devel Apr 17, 2024
37 checks passed
@sultaniman sultaniman deleted the docs/filesystem-layout-extension branch April 17, 2024 14:39
zem360 pushed a commit that referenced this pull request Apr 17, 2024
…1220)

* Add section about new placeholders

* Add basic information about additional placeholders

* Add more examples of layout configuration

* Add code snippet examples

* Remove typing info

* Add note

* Add note about auto_mkdir

* Try concurrent snippet linting

* Try concurrent snippet linting

* Adjust wording and format check_embedded_snippets.py

* Uncomment examples and submit task to pool properly

* Submit snippets to workers

* Revert parallelization stuff

* Comment out unused laoyuts

* Fix mypy issues

* Add a section about the recommended layout

* Adjust text

* Better text

* Adjust section titles

* Adjust code section language identifier

* Fix mypy errors

* More cosmetic changes for the doc

---------

Co-authored-by: Violetta Mishechkina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This issue came from slack community workspace destination Issue related to new destinations documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants