Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESTClient: refactor BasePaginator #1280

Merged
merged 1 commit into from
Apr 25, 2024
Merged

RESTClient: refactor BasePaginator #1280

merged 1 commit into from
Apr 25, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Apr 25, 2024

Description

This PR refactors BasePaginator to:

  • adjust class hierarchy by introducing BaseReferencePaginator as an intermediate class that handles the next reference state management.
  • encapsulate the next_reference attribute (which was publicly accessible) into a protected _next_reference attribute of BaseReferencePaginator.

Related PRs

@burnash burnash self-assigned this Apr 25, 2024
@burnash burnash requested a review from rudolfix April 25, 2024 06:07
@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 686f565
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6629f30e6c1b0f00085ecb59

@burnash burnash mentioned this pull request Apr 25, 2024
Merged
rudolfix
rudolfix approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we should port class tests into a module test at some point

@rudolfix rudolfix merged commit d04f9f4 into devel Apr 25, 2024
48 checks passed
@rudolfix rudolfix deleted the enh/rest_client_refactor_next_reference branch April 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix approved these changes

Assignees

@burnash burnash

Labels
None yet
Projects
dlt core library
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burnash @rudolfix