Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the order of checks for in-memory duckdb option #1333

Closed
wants to merge 4 commits into from
Closed

Fix the order of checks for in-memory duckdb option #1333

wants to merge 4 commits into from

Conversation

sultaniman
Copy link
Contributor

@sultaniman sultaniman commented May 7, 2024 •
edited
Loading

This PR fixes a regression to #1297 where we have been checking prematurely for if database == :memory: and in real life the default native value for duckdb is :memory: which might lead to failures for use cases with default pipeline with ducks like

p = dlt.pipeline(
    pipeline_name="normal-pipeline-with-duckdb",
    destination="duckdb"
)

@sultaniman sultaniman added the bug Something isn't working label May 7, 2024
@sultaniman sultaniman self-assigned this May 7, 2024
@netlify Netlify
Copy link

netlify bot commented May 7, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 5e86a3d
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/663a2428721e9e0008b0352c

@sultaniman sultaniman requested a review from rudolfix May 7, 2024 12:27
@sultaniman sultaniman closed this May 7, 2024
@rudolfix rudolfix deleted the fix/duckdb-in-memory-mode-checks branch May 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix Awaiting requested review from rudolfix

Assignees

@sultaniman sultaniman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sultaniman