Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest_api: add response_actions documentation #1362

Merged
merged 2 commits into from
May 23, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented May 14, 2024

No description provided.

@burnash burnash self-assigned this May 14, 2024
@burnash burnash requested a review from rudolfix May 14, 2024 15:35
Copy link

netlify bot commented May 14, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit ae72b7b
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/664f08ed490e7600086fef14
😎 Deploy Preview https://deploy-preview-1362--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

sultaniman
sultaniman previously approved these changes May 16, 2024
rudolfix
rudolfix previously approved these changes May 16, 2024
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burnash LGTM! just one thought: maybe we should say this is an experimental feature? Or you think we are going to keep the interface

@sh-rp sh-rp added the documentation Improvements or additions to documentation label May 21, 2024
@burnash
Copy link
Collaborator Author

burnash commented May 23, 2024

@burnash LGTM! just one thought: maybe we should say this is an experimental feature? Or you think we are going to keep the interface

good point, I'll add a note

@burnash burnash dismissed stale reviews from rudolfix, sultaniman, and AstrakhantsevaAA via ae72b7b May 23, 2024 09:14
@burnash burnash force-pushed the enh/rest_api/docs/add_response_actions branch from 0140ed2 to ae72b7b Compare May 23, 2024 09:14
@burnash burnash merged commit e449848 into devel May 23, 2024
41 checks passed
@burnash burnash deleted the enh/rest_api/docs/add_response_actions branch May 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants